Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: schedule no show webhooks for requires confirmation event #17089

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: schedule no show webhooks for requires confirmation event #17089

wants to merge 3 commits into from
+64 −0

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented Oct 14, 2024 •
edited
Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

@linear Linear
Copy link

linear bot commented Oct 14, 2024

CAL-4506 Automatic no-show missing triggers

@graphite-app graphite-app bot requested a review from a team October 14, 2024 07:16
@dosubot dosubot bot added this to the v4.6 milestone Oct 14, 2024
@github-actions github-actions bot added enterprise area: enterprise, audit log, organisation, SAML, SSO event-types area: event types, event-types High priority Created by Linear-GitHub Sync webhooks area: webhooks, callback, webhook payload labels Oct 14, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Oct 14, 2024
@dosubot dosubot bot added the 🐛 bug Something isn't working label Oct 14, 2024
Udit-takkar
Udit-takkar commented Oct 14, 2024
View reviewed changes
packages/features/bookings/lib/handleConfirmation.ts
Comment on lines +416 to +427
return tasker.create(
"triggerHostNoShowWebhook",
{
triggerEvent: WebhookTriggerEvents.AFTER_HOSTS_CAL_VIDEO_NO_SHOW,
bookingId: booking.id,
// Prevents null values from being serialized
webhook: { ...webhook, time: webhook.time, timeUnit: webhook.timeUnit },
},
{ scheduledAt }
);
}
return Promise.resolve();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create task for triggerHostNoShowWebhook and triggerGuestNoShowWebhook

@graphite-app Graphite App
Copy link

graphite-app bot commented Oct 14, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (10/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@vercel Vercel
Copy link

vercel bot commented Oct 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 7:59am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 7:59am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐛 bug Something isn't working core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO event-types area: event types, event-types High priority Created by Linear-GitHub Sync webhooks area: webhooks, callback, webhook payload
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

[CAL-4506] Automatic no-show missing triggers
2 participants
@Udit-takkar @keithwillcode